chore: clean up nonce resync worker #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Nov 7, 2024
| // Recycle all nonces between (onchain nonce, db nonce] if they aren't in-flight ("sent nonce"). | ||
| for ( | ||
| let nonce = lastUsedNonceOnchain + 1; | ||
| nonce <= lastUsedNonceDb; |
Contributor
Author
There was a problem hiding this comment.
This is the only intended behavioral change: This worker should try to cancel up to lastUsedNonceDb inclusive, in case the most recent nonce is dropped/missing somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the
nonceResyncWorkerfunctionality by adding error handling, logging, and refining the logic for recycling nonces based on the last used on-chain and database nonces.Detailed summary
prettifyErrorutility for better error formatting.