Fix examples & enums #778
Fix examples & enums #778
Conversation
dirtycajunrice
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
d4mr
left a comment
d4mr
left a comment
There was a problem hiding this comment.
would need to make a pass, remove es-lint related stuff and ignore autogen sdk code for formatter to get a more usable diff
eslint.config.mjs
Outdated
There was a problem hiding this comment.
we use biomejs as standard and had removed eslint
There was a problem hiding this comment.
I didnt add anything, i just migrated the existing config that already existed to one that didnt break.
There was a problem hiding this comment.
I think your formatter run on the autogen code as well, making the code diff hard to see
There was a problem hiding this comment.
I am not auto formatting anything in the SDK. This is what happens if you pull the repo, and run generate:sdk. No changes.
| }); | ||
| it("with leading wildcard", () => { | ||
| expect(sanitizeOrigin("*.foobar.com")).toEqual(RegExp(".*.foobar.com")); | ||
| expect(sanitizeOrigin("*.foobar.com")).toEqual(/.*.foobar.com/); |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to escape the . character in the regular expression to ensure it matches only literal dots and not any character. This can be done by replacing .*.foobar.com with .*\.foobar\.com. This change ensures that the regex will only match subdomains of foobar.com and not any other unintended domains.
| @@ -8,3 +8,3 @@ | ||
| it("with leading wildcard", () => { | ||
| expect(sanitizeOrigin("*.foobar.com")).toEqual(/.*.foobar.com/); | ||
| expect(sanitizeOrigin("*.foobar.com")).toEqual(/.*\.foobar\.com/); | ||
| }); |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
|
I'm pulling pieces from this PR and merging them into main. I won't reopen this unless you want to rebase it (probably more effort than it's worth). |
Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR primarily focuses on code cleanup and refactoring, improving error handling, updating comments, and enhancing type definitions across various services and routes. It also includes modifications to schemas and responses to ensure better clarity and consistency.
Detailed summary
.ideaand JetBrains-related files to.gitignore.catchblocks.letdeclarations toconstwhere applicable for better immutability.getAll()tolist()).testWebhookmethod inWebhooksServicefor testing webhook functionality.