Skip to content

Conversation

@Yash094
Copy link
Member

@Yash094 Yash094 commented Dec 24, 2025

[Playground] Fix: Exclude deprecated chains from x402 network selector

Notes for the reviewer

This change enables the existing disableDeprecated functionality of the SingleNetworkSelector component on the x402 playground page. This ensures that deprecated chains are no longer displayed in the network selection dropdown, consistent with patterns used elsewhere in the codebase.

How to test

  1. Navigate to https://playground.thirdweb.com/x402.
  2. Open the network selector dropdown.
  3. Verify that deprecated chains (e.g., Mumbai) are not listed.

Slack Thread

Open in Cursor Open in Web


PR-Codex overview

This PR introduces a new property to a component, enhancing its functionality by allowing it to disable deprecated features.

Detailed summary

  • Added the disableDeprecated property to the X402LeftSection component.
  • This change modifies the component's behavior, likely affecting how deprecated features are handled.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Updated component configuration to disable deprecated options in the network selector.

✏️ Tip: You can customize this high-level summary in your review settings.

Co-authored-by: yashjoisar <yashjoisar@thirdweb.com>
@cursor
Copy link

cursor bot commented Dec 24, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: 7e530fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
thirdweb_playground Ready Ready Preview, Comment Dec 24, 2025 3:31pm
4 Skipped Deployments
Project Deployment Review Updated (UTC)
docs-v2 Skipped Skipped Dec 24, 2025 3:31pm
nebula Skipped Skipped Dec 24, 2025 3:31pm
thirdweb-www Skipped Skipped Dec 24, 2025 3:31pm
wallet-ui Skipped Skipped Dec 24, 2025 3:31pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Walkthrough

A disableDeprecated prop was added to the SingleNetworkSelector component usage in the X402LeftSection without modifications to logic or state management.

Changes

Cohort / File(s) Summary
X402 Component Enhancement
apps/playground-web/src/app/x402/components/X402LeftSection.tsx
Added disableDeprecated prop to SingleNetworkSelector component instance

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'X402 playground chainlist' is vague and generic, failing to clearly communicate the primary change of excluding deprecated chains from the network selector. Revise the title to be more specific about the change, such as 'Fix: Exclude deprecated chains from X402 playground network selector' to better align with the PR template and actual changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the template structure with proper sections, clear notes for reviewers, and detailed testing instructions, effectively communicating the intent and implementation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/x402-playground-chainlist-0d66

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 245e9a6 and 7e530fb.

📒 Files selected for processing (1)
  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoid any and unknown in TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.) in TypeScript

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose

Files:

  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
apps/{dashboard,playground-web}/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/{dashboard,playground-web}/src/**/*.{ts,tsx}: Import UI component primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground
Use Tailwind CSS only – no inline styles or CSS modules in dashboard and playground
Use cn() from @/lib/utils for conditional Tailwind class merging
Use design system tokens for styling (backgrounds: bg-card, borders: border-border, muted text: text-muted-foreground)
Expose className prop on root element for component overrides

Files:

  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
**/*.{js,jsx,ts,tsx,json}

📄 CodeRabbit inference engine (AGENTS.md)

Biome governs formatting and linting; its rules live in biome.json. Run pnpm fix & pnpm lint before committing, ensure there are no linting errors

Files:

  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Lazy-import optional features; avoid top-level side-effects

Files:

  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
🔇 Additional comments (1)
apps/playground-web/src/app/x402/components/X402LeftSection.tsx (1)

131-131: LGTM! Clean implementation of the disableDeprecated feature.

The addition of the disableDeprecated prop correctly enables filtering of deprecated chains (like Mumbai) from the network selector. The SingleNetworkSelector component properly supports this prop and uses it to exclude chains with deprecated status. The boolean literal is appropriate for this playground page context.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.19%. Comparing base (245e9a6) to head (7e530fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8588   +/-   ##
=======================================
  Coverage   53.19%   53.19%           
=======================================
  Files         922      922           
  Lines       61480    61480           
  Branches     4032     4032           
=======================================
  Hits        32706    32706           
  Misses      28676    28676           
  Partials       98       98           
Flag Coverage Δ
packages 53.19% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@Yash094 Yash094 marked this pull request as ready for review December 24, 2025 15:33
@Yash094 Yash094 requested review from a team as code owners December 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants