-
Notifications
You must be signed in to change notification settings - Fork 631
Checkout widget transaction hash #8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: yashjoisar <yashjoisar@thirdweb.com>
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: e7949ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8589 +/- ##
=======================================
Coverage 53.19% 53.19%
=======================================
Files 922 922
Lines 61480 61480
Branches 4032 4032
=======================================
Hits 32706 32706
Misses 28676 28676
Partials 98 98
🚀 New features to boost your workflow:
|
size-limit report 📦
|
[Dashboard/Portal] Feature: Return transaction hash in Checkout Widget iframe events
Notes for the reviewer
transactionsarray in bothsuccessanderrorpostMessageevents.{ chainId, transactionHash }objects for all relevant on-chain transactions.errorevents, thetransactionsarray may contain partial data if the error occurred mid-flow.TRANSACTION_HASH_EXAMPLE.html) is included for easy testing.How to test
apps/dashboard/src/app/bridge/checkout-widget/TRANSACTION_HASH_EXAMPLE.htmlin a browser.transactionsarray in the success event log on the right.transactionsarray (if any) in the error event log.Slack Thread
PR-Codex overview
This PR adds transaction hash information to the checkout widget iframe's success and error events, enabling developers to track on-chain transactions associated with payments made through the widget.
Detailed summary
onSuccessandonErrorhandlers inCheckoutWidgetEmbed.client.tsxto include transaction hashes.page.mdxwith examples for success and error events.TRANSACTION_HASH_EXAMPLE.htmlto demonstrate event logging..changeset/checkout-widget-transaction-hash.mdfor release notes.