Skip to content

Fixed storage get_url() token bug #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed storage get_url() token bug #417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a1d155
Fixed storage get_url() token bug
hereisamara Apr 10, 2022
fb4a3a0
Fixed storage get_url() token bug
hereisamara Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pyrebase/pyrebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,13 +426,21 @@ def download(self, filename, token=None):
for chunk in r:
f.write(chunk)

def get_url(self, token):
def get_url(self, token=None):
path = self.path
self.path = None
headers = {}
if path.startswith('/'):
path = path[1:]
if token:
return "{0}/o/{1}?alt=media&token={2}".format(self.storage_bucket, quote(path, safe=''), token)
headers = {"Authorization": "Firebase " + token}
# retrieve download tokens first
request_ref = "{0}/o/{1}".format(self.storage_bucket, quote(path, safe=''))
request_object = self.requests.post(request_ref, headers=headers)
raise_detailed_error(request_object)
access_tokens = request_object.json()['downloadTokens'].split(",")
if len(access_tokens) > 0:
return "{0}/o/{1}?alt=media&token={2}".format(self.storage_bucket, quote(path, safe=''), access_tokens[0])
return "{0}/o/{1}?alt=media".format(self.storage_bucket, quote(path, safe=''))

def list_files(self):
Expand Down