fix: properly shuffle around sortables when draghandle is separate div #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh, interesting. I'll take a closer look at this next week and see about merging it in. Thanks! |
sowiner
added a commit
to sowiner/solid-dnd
that referenced
this pull request
Jan 8, 2025
|
@martinpengellyphillips sorry for pinging, but I would love this fix to be available 😅 |
|
@martinpengellyphillips any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for all your work on this awesome library!
I tried implementing the separate drag handler with sortable as described in #84, but I noticed that the sortables weren't shuffling around as I dragged it around anymore. I think I narrowed down the problem, with a fix that I've included in this PR.
Before:
After:
Let me know if there's anything you'd like to change about the implementation, or feel free to edit it yourself. I'm not the most attentive to github notifications, but I'll try my best to respond 😅