Early returns for empty data #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Oct 8, 2025
Comment on lines
189
to
194
| compute_layer = function(data, params, layout) { | ||
| if (empty(data)) { | ||
| return(data) | ||
| } | ||
| StatEdgeLink2$compute_layer(data, params, layout) | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
Arguably it'd be better to handle this in ggforce::StatLink2.
teunbrand
commented
Oct 8, 2025
Comment on lines
-237
to
-239
| if (nrow(data) == 0) { | ||
| return(data) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Because data was returned regardless of the condition, I removed these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #370.
It reviews all the Stats defined in ggraph and inserts early returns of empty data.