Conversation
Retire ClientServerSimulator in favor of testing with a VM
Use stock Harmony with direct calls to MonoMod where necessary
simplify replay logic
Fix/science unlocks
* sync mechanical fluid pumps * Remove exception for invalid mode in ToActionString --------- Co-authored-by: samuzad <zadori.samu@gmail.com>
Owner
Author
|
Just wanted to apologize for some git shenanigans due to a mistake. FYI I'm trying to merge things into dev for a short-term release with Automation and other sync fixes from @SamuZad while still testing Harmony and other giant change features for a slightly later release. Anyway, I've got that working, but it did result in some cherrypicking and duplicate commits. Apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all the changes from prior PRs that need to be tested more thoroughly together. I'm using it as a way to track things I need to test as I see them in the code I'm reviewing. Suggestions welcome.
Things to test first:
integrationas I merge PRs there