Skip to content

Conversation

@atoaster
Copy link

Returns the timedelta of the total union of two DateTimeRange's

@thombashi thombashi self-requested a review December 13, 2020 05:40
Returns the timedelta of the union of the input and current
DateTimeRange.
:param DateTimeRange x: List of DateTimeRanges.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x is not a List of DateTimeRange instances judging from what the method does.

@thombashi
Copy link
Owner

@atoaster
Thank you for your PR.

The method looks like useful for some use cases.
What concerns me is that the method name deviates from what the method does.
The method return value is not returning a union of DateTimeRange but timedelta.
I think that union_timedelta or something would be more suitable name for the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants