Conversation
Contributor
|
@davidrs what's needed for this to be finished? |
Contributor
Author
|
it was not reproing the bug i was trying to debug so i abandoned it, but probably no reason not to merge |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for video files that contain additional channels beyond the primary video stream, such as audio or thumbnail (attached picture) channels.
Changes:
- Adds a new test function
test_videos_with_extra_channels()to verify that the video reading functionality correctly handles multichannel videos
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video may have audio or a thumbnail channel, this adds tests for that