dependency of lxml, seems to be missing. so fix it.#27
Merged
thorstenb merged 2 commits intothorstenb:masterfrom May 2, 2015
Merged
dependency of lxml, seems to be missing. so fix it.#27thorstenb merged 2 commits intothorstenb:masterfrom
thorstenb merged 2 commits intothorstenb:masterfrom
Conversation
Owner
|
That breaks the travis build - and incidentally, is that a transitive dependency from lpod-python per chance? See also #24 |
Contributor
Author
|
Fix travis. looks work well now. In my env, |
Owner
|
Ah thx, nice catch! |
thorstenb
added a commit
that referenced
this pull request
May 2, 2015
Add dependency for lxml, seems to be missing from lpod.
Contributor
Author
|
thx! 👍 |
Contributor
|
The README and setup.py hunk are wrong though, you are adding a dependency for a library you are not directly using. Requirements update should be enough until fixed upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency of lxml written in
odpdown.egg-info/requires.txt,but not written in
requirements.txtandsetup.py.So I add lxml dependency.
regards.