This repository was archived by the owner on Mar 21, 2020. It is now read-only.
Open
Conversation
added 2 commits
June 6, 2018 10:29
Merely pushing to the registry doesn't deploy to Heroku. The additional container:release step is required. Thoughtbot's Heroku app name was hardcoded in the script. The new `HEROKU_APP_NAME` env variable allows it to be changed per installation. Running as a "web" process failed because Heroku expected it to listen to a port. This reclassifies it as a "worker" process. REDIS_URL is added to `env` because it's a required env variable.
tonyd256
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merely pushing to the registry doesn't deploy to Heroku. The additional
container:releasestep is required.Thoughtbot's Heroku app name was hardcoded in the script. The new
HEROKU_APP_NAMEenv variable allows it to be changed per installation.Running as a "web" process failed because Heroku expected it to listen to a port and aborted after 60s. This reclassifies it as a "worker" process.
REDIS_URLis added toenvbecause it's a required env variable.#32 should be merged before this.