Skip to content

Fix network & gateways deletion in k8s #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix network & gateways deletion in k8s #4407

wants to merge 2 commits into from

Conversation

@zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Oct 26, 2025 •
edited
Loading

Changes

  • Add deleteK8sGateways() to clean up gateway contracts before K8s deletion
  • Collect IPs from all cluster nodes (masters + workers)
  • Delete associated gateways first, allowing proper network contract cleanup

#4255

@zaelgohary zaelgohary marked this pull request as draft October 29, 2025 09:44
@zaelgohary
Collect K8s IPs from masters and workers to drive gateway cleanup, cl…
f812e91 
…ean residual network contracts when no workloads remain
@zaelgohary zaelgohary marked this pull request as ready for review October 29, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zaelgohary