Skip to content

Conversation

@AlaaElattar
Copy link
Contributor

Changes

  • Handled connectivity check and timeout for news, signing and wallet screens.

Related Issues

#1025

Tested Scenarios

  • Tested all screens with no and bad internet connection.

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News screen shows errors in a toast and persistent in the screen itself. This doesn't happen anywhere else. Can we remove the persistent one for consistency?

@zaelgohary
Copy link
Contributor

zaelgohary commented May 21, 2025

It might not be intuitive for the user to click the reload button, as it doesn't stand out on the page, while the dropdown already contains the wallets' names. What if we checked for connectivity in the sign screen instead, and show the try again button as in other screens?

@AlaaElattar AlaaElattar marked this pull request as draft May 27, 2025 13:26
@AlaaElattar AlaaElattar marked this pull request as ready for review May 27, 2025 13:57
@AlaaElattar AlaaElattar requested a review from zaelgohary May 27, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants