Skip to content

sort nodes by status #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

sort nodes by status #1070

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65bda2b
sort nodes by status
AlaaElattar May 29, 2025
fe0e58b
move sorted nodes computations outside ListView.builder
AlaaElattar Jun 19, 2025
ae12715
Merge branch 'development' into development_nodes
AlaaElattar Jun 19, 2025
5810243
fix conflict
AlaaElattar Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/lib/screens/farm_details.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,16 @@ class _FarmDetailsState extends State<FarmDetails> {

@override
Widget build(BuildContext context) {
final sortedNodes = List.from(widget.farm.nodes)
..sort((a, b) {
if (a.status == NodeStatus.Up && b.status != NodeStatus.Up) {
return -1;
} else if (a.status != NodeStatus.Up && b.status == NodeStatus.Up) {
return 1;
} else {
return 0;
}
});
return Scaffold(
appBar: AppBar(
title: Text(widget.farm.name),
Expand Down Expand Up @@ -526,9 +536,9 @@ class _FarmDetailsState extends State<FarmDetails> {
ListView.builder(
shrinkWrap: true,
physics: const NeverScrollableScrollPhysics(),
itemCount: widget.farm.nodes.length,
itemCount: sortedNodes.length,
itemBuilder: (context, index) {
final node = widget.farm.nodes[index];
final node = sortedNodes[index];
return Card(
margin: const EdgeInsets.symmetric(
vertical: 4.0, horizontal: 0.0),
Expand Down