Add contracts screen #1079
Add contracts screen #1079
Conversation
zaelgohary
changed the title
…contract details, fix name contract type err
| Widget build(BuildContext context) { | ||
| try { | ||
| List<Widget> detailRows = []; | ||
| final contractDetails = extractContractDetails(contract); |
There was a problem hiding this comment.
what if the function returned an empty map ?
There was a problem hiding this comment.
ExtractContractDetails can't return an empty map as it always populates the first 5 fields.
threefold_connect/app/lib/helpers/contract_helpers.dart
Lines 54 to 58 in 4649597
| import 'package:intl/intl.dart'; | ||
| import 'package:threebotlogin/main.dart'; | ||
|
|
||
| String capitalizeFirstLetter(String text) { |
There was a problem hiding this comment.
The renaming is misleading, it's not actually capitalizing the first letter.
| } | ||
| } | ||
|
|
||
| Map<String, String> extractContractDetails(ContractInfo contract) { |
There was a problem hiding this comment.
In ContractInfo, the data already extracted based on the contract type.
What is the point of this function ?
There was a problem hiding this comment.
I mapped over the data to make it iterable in the build widget. Removed extractContractDetails and showed data directly.
| import 'package:intl/intl.dart'; | ||
| import 'package:threebotlogin/main.dart'; | ||
|
|
||
| String formatStatus(String text) { |
There was a problem hiding this comment.
I suggest implementing smth like that
const statusDisplayNames = {
'created': 'Created',
'graceperiod': 'Grace Period',
};What do u think ?
Changes
Related Issues
Tested Scenarios
Navigate to contracts