Skip to content

Improvement/metadata on jsonapi render #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvement/metadata on jsonapi render #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1cfa1
feature(formatter): Adds support for in options passed through jsona…
Jul 5, 2018
343112e
fix(formatters.rb): indentation
Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/jsonapi/utils/response/formatters.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ def turn_into_resource(record, options)
# @api private
def result_options(records, options)
{}.tap do |data|
data[:meta] = options.fetch(:meta, {})
Copy link

@npendery npendery Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if data[:meta] has record counts already, but id maybe merge the two instead of assigning

Copy link

@kceb kceb Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data[:meta] = options.fetch(:meta, {})
data[:meta] = data.fetch(:meta, {}).merge(options.fetch(:meta, {}))


if JSONAPI.configuration.default_paginator != :none &&
JSONAPI.configuration.top_level_links_include_pagination
data[:pagination_params] = pagination_params(records, options)
Expand Down