fix(cli): wait trailing ACP updates before turn complete#356
Closed
xxbbzy wants to merge 2 commits intotiann:mainfrom
Closed
fix(cli): wait trailing ACP updates before turn complete#356xxbbzy wants to merge 2 commits intotiann:mainfrom
xxbbzy wants to merge 2 commits intotiann:mainfrom
Conversation
- add Bark delivery + notification channel with retry and timeout handling - wire Bark settings into hub configuration and startup logs - add unit tests for Bark delivery/channel and channel-failure isolation in notification hub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- None
Summary
- Review mode: initial — no issues found in the diff. Residual risks: Bark delivery relies on external service availability and network behavior; only unit-level coverage added here.
Testing
- Not run (automation). Suggested:
bun run test hub/src/notifications/barkDelivery.test.ts hub/src/notifications/barkNotificationChannel.test.ts
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification