AuthTests: TokenRepository resilience tests #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asendra
force-pushed
the
auth/edge-case-tests
branch
2 times, most recently
from
6b5ab36 to
8d40b4c
Compare
asendra
force-pushed
the
auth/retry-jitter
branch
from
e0b49ea to
e7e1e32
Compare
Base automatically changed from
auth/retry-jitter
to
fix/auth-server-error-handling
October 6, 2025 07:40
asendra
force-pushed
the
auth/edge-case-tests
branch
from
8d40b4c to
0480a2f
Compare
asendra
changed the base branch from
fix/auth-server-error-handling
to
auth/refresh-coalescing
asendra
force-pushed
the
auth/edge-case-tests
branch
from
0480a2f to
ae28229
Compare
asendra
force-pushed
the
auth/refresh-coalescing
branch
from
237e28f to
45b76c5
Compare
asendra
force-pushed
the
auth/edge-case-tests
branch
4 times, most recently
from
c11afad to
55b0998
Compare
asendra
force-pushed
the
auth/edge-case-tests
branch
from
022ca36 to
232cc69
Compare
…401, store failures with XCTExpectFailure, cooldown TODO)
The new coalescing + transient error handling provides implicit cooldown: - First call on 503: attempts refresh, returns stored credentials - Second call: credentials not expired, returns cached without refresh This is improved behavior that prevents hammering the server after transient failures. Updated test name and assertions to verify this implicit cooldown via stored credentials pattern. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
asendra
force-pushed
the
auth/edge-case-tests
branch
from
232cc69 to
bb71731
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive resilience tests for TokenRepository to validate behavior under edge cases like rate limiting, concurrent refresh operations, persistence failures, and repeated transient errors. These tests document current behavior and help prevent forced logouts or session breakage when access tokens expire quickly.
Key Changes:
- Introduces
TokenRepositoryResilienceTestscovering rate limits, concurrent refresh coalescing, persistence failures, and transient error handling - Adds specialized test doubles (
FailingFakeTokensStore,SequencedFakeTokenService) for deterministic failure scenarios - Documents current throwing behavior for persistence failures to guide future soft-fail improvements
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Strengthen coverage for scenarios that historically lead to forced logouts or broken sessions when access tokens expire quickly: rate limiting, concurrent refresh, persistence failures, and repeated transient errors.
What
TokenRepositoryResilienceTestscovering:FailingFakeTokensStore,SequencedFakeTokenService) to drive the scenarios deterministically.Notes
auth/refresh-coalescing(RefreshCoordinator injection).Tests
swift test --filter TokenRepositoryResilienceTests