add ReadOnly mode and change IsoCopy behavior#40
Open
yihuang wants to merge 4 commits intotidwall:masterfrom
Open
add ReadOnly mode and change IsoCopy behavior#40yihuang wants to merge 4 commits intotidwall:masterfrom
yihuang wants to merge 4 commits intotidwall:masterfrom
Conversation
yihuang
commented
Jan 4, 2026
yihuang
commented
Jan 4, 2026
Author
|
To elaborate on this, the read-only mode is to avoid the mutation on the origin tree's |
yihuang
commented
Jan 4, 2026
| defer tr.unlock(!tr.readOnly) | ||
| } | ||
| if !tr.readOnly { | ||
| tr.isoid = newIsoID() |
Author
There was a problem hiding this comment.
The read-only mode is mainly to avoid the mutation on this field, so that we can have a fully read-only tree instance but supports IsoCopy method at the same time.
Author
There was a problem hiding this comment.
An alternative approach is to simply add a new method IsoCopyReadOnly without adding a new mode, and make it callers's responsibility to avoid modify the origin tree in place. That'll make the PR less intrusive. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I'm experimenting with the optimistic concurrency control pattern using the
IsoCopyfeature, it should be useful in read-heavy scenarios, this patch is some necessary changes to enable this pattern.The performance difference of different concurrency control strategies differs a lot based on the workload, for my local testing scenario, the CAS is faster than
Mutexin some cases, but slower in some other extreme cases, but both are much faster thanRWMutex.