Open
Conversation
…ache}.c] Resolve some warnings
…fo.h.in (reverse-engineering Makefile) ; add OpenSSL ; [CMakeLists.txt] Disable OpenSSL if flag provided ; [README.md] Add guide for using CMake
…s.txt] Add flags to better reflect project requirements ; [src/*.c] Minor changes to get it to build with no warnings
…`NOURING`) ; [README.md] Bump version
starius
reviewed
Jul 25, 2025
CMakeLists.txt
Outdated
| if (APPLE) | ||
| set(CPACK_BUNDLE_PLIST "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Info.plist") | ||
| set(CPACK_BUNDLE_ICON "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Info.plist") | ||
| set(CPACK_PACKAGE_ICON "${CMAKE_CURRENT_SOURCE_DIR}/cmake/CustomVolumeIcon.icns") |
There was a problem hiding this comment.
Why binary file CustomVolumeIcon.icns is needed? Can it be generated somehow not to put binary blobs to Git?
Author
There was a problem hiding this comment.
Oh it's just from the tutorial; it makes it easy for you to replace it with the icon for pogocache
# Conflicts: # README.md
| assert(status == POGOCACHE_INSERTED || status == POGOCACHE_REPLACED); | ||
| if (conn_proto(conn) == PROTO_POSTGRES) { | ||
| char val[24]; | ||
| char buf1[24]; |
Contributor
There was a problem hiding this comment.
Are the renamings only cosmetic?
Author
There was a problem hiding this comment.
Same function two vars:
https://github.com/tidwall/pogocache/blob/0c94bbb/src/cmds.c#L1562
https://github.com/tidwall/pogocache/blob/0c94bbb/src/cmds.c#L1584
I.e., variable shadowing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6