fix(path_generator): prevent path truncation before current lanelet#85
Open
ToshifumiTeranishi wants to merge 1 commit intobeta/v0.65from
Open
fix(path_generator): prevent path truncation before current lanelet#85ToshifumiTeranishi wants to merge 1 commit intobeta/v0.65from
ToshifumiTeranishi wants to merge 1 commit intobeta/v0.65from
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in
path_generatorwhere the path is prematurely truncated before reaching the ego vehicle's current lanelet, causing aFailed to build trajectory from path pointserror.Since the introduction of
RouteManagerin PR autowarefoundation#803, the lanelet sequence is provided and processed as a single continuous array ([backward] -> [current] -> [forward]). However, the forward path truncation logic calculates the accumulated distancesstarting from the very beginning of this sequence. If the backward lanelets are physically long,scan exceed the truncation threshold (s_end) before the loop reaches the ego'scurrent_lanelet. This triggers an earlybreakand erases the ego's current and forward lanelets.To resolve this, a
current_lanelet_seenguard flag was added in the sequence iteration loop. This ensures that the forward path truncation (lanelets.eraseandbreak) only triggers after the ego vehicle's current lanelet has been explicitly passed and thes_endthreshold is correctly updated.Related links
Internal: https://star4.slack.com/archives/C017VB9UG1L/p1773728712843039
How was this PR tested?
https://evaluation.tier4.jp/evaluation/reports/d62e78b0-3b31-5c6b-8f05-b560bc5e2d32?project_id=X8ft5pPN
https://evaluation.tier4.jp/evaluation/reports/31af6aad-f4b4-5f21-9ece-70af0a66e416?project_id=X8ft5pPN
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.