fix: Use putArchive instead of exec for session file copying #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copySessionFileToContainer method was using container.exec() to copy session files, but exec requires a running container. Since session files are copied before container.start(), this caused HTTP 409 errors: "container is not running" Replace exec with tar-stream + putArchive which works on stopped containers. File ownership is set via tar headers (uid/gid 1000) instead of chown. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
…ainer-not-running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
--prefer-sessionflagcontainer.exec()withtar-stream+container.putArchive()for copying session filesputArchiveworks on stopped containers (beforecontainer.start()), whileexecrequires running containersTest Plan
runCommandandrunCommandStreaming--prefer-sessionflagShare Nori with your team: https://www.npmjs.com/package/nori-ai