This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Decrease the time locks are held during duplicate copy #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the order of operations from: COPY to temp_metric1 INSERT from temp_metric_1 to metric_1 ON CONFLICT DO NOTHING COPY to temp_metric2 INSERT from temp_metric_2 to metric_2 ON CONFLICT DO NOTHING to COPY to temp_metric1 COPY to temp_metric2 INSERT from temp_metric_1 to metric_1 ON CONFLICT DO NOTHING INSERT from temp_metric_2 to metric_2 ON CONFLICT DO NOTHING By combining the inserts together at the end of the transaction it decreases the times that locks on conflicting rows are held.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the order of operations from:
COPY to temp_metric1
INSERT from temp_metric_1 to metric_1 ON CONFLICT DO NOTHING COPY to temp_metric2
INSERT from temp_metric_2 to metric_2 ON CONFLICT DO NOTHING
to
COPY to temp_metric1
COPY to temp_metric2
INSERT from temp_metric_1 to metric_1 ON CONFLICT DO NOTHING INSERT from temp_metric_2 to metric_2 ON CONFLICT DO NOTHING
By combining the inserts together at the end of the transaction it decreases the times that locks on conflicting rows are held.
Description
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: