Skip to content

Conversation

@syvb
Copy link

@syvb syvb commented Nov 20, 2025

Supports changing the CPU/RAM of instances.

@syvb syvb marked this pull request as ready for review November 24, 2025 06:43
@syvb
Copy link
Author

syvb commented Nov 24, 2025

The frontend doesn't let you resize between shared and non-shared, so I didn't add shared to the list of resize options. But right now it will still let you resize a shared instance to a non-shared instance, which doesn't actually work (the API response is successful, but nothing changes). I think the right approach is to fix the backend so that it gives a proper error here.

@syvb syvb changed the title Support resizing services (WIP) Support resizing services Nov 24, 2025
Copy link
Member

@nathanjcochran nathanjcochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I left a bunch of comments, but they're mostly minor stylistic or structural/organizational things.

I think the biggest issues are:

  • Your branch is decently far behind main at this point. I think you should merge in main, resolve the conflicts, and update things to use the latest patterns. See my comments below for more info.
  • I think we should update the resize REST API endpoint to accept the CPU and memory values as strings instead of as integers before releasing this (for consistency with the other endpoints, and for more flexibility going forwards). If we don't do that now, it's going to be much harder to do in the future while maintaining backwards-compatibility with existing versions of the CLI. I think there are some other things we should fix with that endpoint too, like getting rid of the unused nodes parameter. In general, we've been reviewing and improving the REST API endpoints every time we implement a new CLI command, so I think it's worth doing that in this case too.
  • It would be good to add some integration tests for the new resize command. See integration_test.go. You can probably just add a new subtest in TestServiceLifecycleIntegration.

Thanks for tackling this! 🙏

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants