Skip to content

Conversation

@natesales
Copy link
Contributor

@natesales natesales commented Oct 17, 2025

Summary by cubic

Adds automatic router selection for Tinfoil clients. If no enclave is provided, the client fetches available SNP routers from ATC and picks one. Defaults now target the confidential model router.

  • New Features

    • Added get_router_address() to query https://atc.tinfoil.sh/routers?platform=snp and return a random router.
    • SecureClient, TinfoilAI, AsyncTinfoilAI, and NewSecureClient now auto-select a router when enclave is empty; default repo is tinfoilsh/confidential-model-router.
    • Updated tests to use router addresses.
  • Dependencies

    • Bumped package version to 0.10.0.
    • Upgraded sigstore to >=4.1.0 and removed unused imports.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="tests/test_attestation_flow.py">

<violation number="1" location="tests/test_attestation_flow.py:15">
Import-time call to get_router_address() performs a network request; if ATC is unavailable, the import raises and pytest cannot collect this test. Fetch the router lazily (e.g., inside the test) or add resilient fallback instead of calling it at module scope.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@natesales natesales merged commit fe90b46 into main Oct 17, 2025
1 check passed
@natesales natesales deleted the nate/router branch October 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants