Fix: certificate name mixup and AMD bit check condition #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the ARK and ASK certificates were swapped. Fixed to match: https://github.com/google/go-sev-guest/blob/main/verify/trust/ask_ark_genoa.pem
Previously, the condition of checking 63-26 were zero was too strict and didn't match the latest AMD spec which has 63-26 as expected to be zero. Note: abi_sevsnp.py correctly checks that 63-26 are zero.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixed swapped AMD Genoa certificates and updated policy bit validation to match the SEV-SNP spec. This restores correct certificate chain validation and prevents false report rejections.
Written for commit 362467c. Summary will update automatically on new commits.