Skip to content

Simplify argument validation#25

Merged
tingerrr merged 3 commits intomainfrom
tingerrr/rqlnqrxklroq
Feb 10, 2025
Merged

Simplify argument validation#25
tingerrr merged 3 commits intomainfrom
tingerrr/rqlnqrxklroq

Conversation

@tingerrr
Copy link
Owner

@tingerrr tingerrr commented Feb 7, 2025

See commit messages.

Closes #8 and #24.

@tingerrr tingerrr force-pushed the tingerrr/rqlnqrxklroq branch 3 times, most recently from 0c58956 to bf98cb7 Compare February 7, 2025 17:15
@tingerrr tingerrr changed the title [WIP] Simplify argument validation Simplify argument validation Feb 7, 2025
@tingerrr tingerrr marked this pull request as ready for review February 7, 2025 17:16
@tingerrr tingerrr force-pushed the tingerrr/rqlnqrxklroq branch 3 times, most recently from 9576378 to af2a459 Compare February 7, 2025 17:19
@tingerrr
Copy link
Owner Author

tingerrr commented Feb 8, 2025

I'll merge this and release an update after I released tytanic v0.1.2, which should be more or less ready, I'm just waiting to see if I find any bugs while using it.

Simplify the function signatures to a) not need any validation as it will be
done by the figure and grid function respectively and b) to not override style
chain values.

Update tests and documentation, update to tytanic.

Closes #8 and #24.
@tingerrr tingerrr force-pushed the tingerrr/rqlnqrxklroq branch from af2a459 to 0582d9b Compare February 10, 2025 15:33
@tingerrr tingerrr merged commit 08feb2e into main Feb 10, 2025
1 check passed
@tingerrr tingerrr deleted the tingerrr/rqlnqrxklroq branch February 10, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer named sink args to prevent overriding defaults set with show rule

1 participant