Remove absolute path from util.typ preventing usgae via usage as submodule#35
Merged
tingerrr merged 2 commits intotingerrr:mainfrom Mar 21, 2025
embRoobin:main
Merged
Remove absolute path from util.typ preventing usgae via usage as submodule#35tingerrr merged 2 commits intotingerrr:mainfrom embRoobin:main
tingerrr merged 2 commits intotingerrr:mainfrom
embRoobin:main
Conversation
#import "modules/subpar/src/lib.typ" as subpar
Owner
|
Not the biggest fan of relative paths for asset paths, but the package is simple, and it doesn't hurt here. Could you update the changelog alongside this? |
Contributor
Author
|
Done 👍🏻 I also do not like the usage from local folders or submodules, but unfortunately i have to deal with some nasty proxy environment... |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the absolute path reference to the assets folder.
Allows usage via local import without errors.