fix(darwin): add DidFailToConnectPeripheral handler#430
Open
acouvreur wants to merge 1 commit intotinygo-org:devfrom
Open
fix(darwin): add DidFailToConnectPeripheral handler#430acouvreur wants to merge 1 commit intotinygo-org:devfrom
acouvreur wants to merge 1 commit intotinygo-org:devfrom
Conversation
Member
|
Is there any way to test this out @acouvreur? |
Contributor
Author
Rare cases when you connect to a device and it fails for some reason, like you were too far from the device but close enough to get signal. Based on CoreBluetooth documentation, it is clear to me that we need this handler in case of error, because right now only the happy path is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Connect on peripherals with an unstable state, I've found that it might be because of the missing
DidFailToConnectPeripheralhandler (https://developer.apple.com/documentation/corebluetooth/cbcentralmanagerdelegate/centralmanager(_:didfailtoconnect:error:)?language=objc)So this should properly handle the connection failed event.
Note:
I would like to be able to use that error object. However, it requires to completely change the channel type.
I might do another PR later.