crypto/rand: return correct count on hardware RNG read error#5265
Open
cuiweixie wants to merge 1 commit intotinygo-org:devfrom
Open
crypto/rand: return correct count on hardware RNG read error#5265cuiweixie wants to merge 1 commit intotinygo-org:devfrom
cuiweixie wants to merge 1 commit intotinygo-org:devfrom
Conversation
When machine.GetRNG fails mid-read, return the number of bytes already written (i) instead of n, which is still zero at that point.
Member
|
Hello @cuiweixie thanks for the PR. I changed the branch to As far as the content, is the current behavior of returning 0 the right choice for when an error in RNG has occurred? Can we depend on the values that were returned so far when an error condition has occurred? I would guess yes. Could you please describe the situation that resulted in you needing this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the baremetal
crypto/randreader so that whenmachine.GetRNG()fails after some bytes were already written,Readreturns(i, err)instead of(n, err). Previouslynwas still zero, so callers could not tell how many bytes were valid.Testing
Not run (small one-line semantic fix; hardware RNG path).