Conversation
- Eliminated `crypto/md5` from WASM build (Attachments). - Unified Font and Image ID generation logic, removing `crypto/sha1`. - Unified Font JSON unmarshaling using `tinywasm/json`. - Unified time handling to use `int64` (Unix nanoseconds) across all platforms. - Isolated backend-only dependencies (`os`) using build tags and `_back.go` files. - Updated `tinywasm/json` to v0.4.1 and `tinywasm/fmt` to v0.22.2 to fix `[]int` decoding. - Updated tests to match the new unified API. - Fixed `fontDefType` schema to support `[]int` decoding with `fmt.FieldIntSlice`. Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements the optimization and unification plan described in
docs/PLAN.mdto reduce WASM binary size and simplify the codebase. Key changes include the removal of heavy standard library dependencies (crypto/md5,crypto/sha1,time,os) from the WASM build, unification of previously platform-split files, and a fix for JSON decoding of character width slices. All tests pass and the WASM build is verified.PR created automatically by Jules for task 18442472867639477928 started by @cdvelop