Skip to content

Feature: voyage ai embedding support#99

Closed
loc4atnt wants to merge 2 commits intotirth8205:mainfrom
loc4atnt:feature/voyage-ai-embedding-support
Closed

Feature: voyage ai embedding support#99
loc4atnt wants to merge 2 commits intotirth8205:mainfrom
loc4atnt:feature/voyage-ai-embedding-support

Conversation

@loc4atnt
Copy link
Copy Markdown

@loc4atnt loc4atnt commented Apr 4, 2026

I've added Voyage AI embedding support and some guidance for the embedding config in the README file

@tirth8205
Copy link
Copy Markdown
Owner

Thanks for adding Voyage AI support — the embedding provider changes look reasonable! However, this PR has some issues that prevent merging:

  1. Deletes CLAUDE.md (-107 lines) — this is essential project config
  2. Deletes uv.lock (-3,370 lines) — this is our lockfile
  3. Commits spec documents under specs/ — these shouldn't be in the repo

If you'd like to resubmit, please create a clean PR that only includes the Voyage AI embedding changes in embeddings.py (and matching tests). Happy to review that!

@tirth8205 tirth8205 closed this Apr 8, 2026
@tirth8205
Copy link
Copy Markdown
Owner

Voyage AI embedding support is not in main — embeddings.py only has local (sentence-transformers), Google Gemini, and MiniMax providers. Worth reviving if the implementation quality is good. However, note that this PR has 951 additions and 3492 deletions which is unusual — the deletions count may indicate it touched a lot of existing code. Recommend reviewing the diff carefully before reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants