Feature: voyage ai embedding support#99
Closed
loc4atnt wants to merge 2 commits intotirth8205:mainfrom
Closed
Conversation
Owner
|
Thanks for adding Voyage AI support — the embedding provider changes look reasonable! However, this PR has some issues that prevent merging:
If you'd like to resubmit, please create a clean PR that only includes the Voyage AI embedding changes in |
Owner
|
Voyage AI embedding support is not in main — embeddings.py only has local (sentence-transformers), Google Gemini, and MiniMax providers. Worth reviving if the implementation quality is good. However, note that this PR has 951 additions and 3492 deletions which is unusual — the deletions count may indicate it touched a lot of existing code. Recommend reviewing the diff carefully before reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added Voyage AI embedding support and some guidance for the embedding config in the README file