Skip to content

Conversation

@joshmcrae
Copy link
Member

This PR adds more comprehensive tests for TableOperation and fixes some bugs with the application of column operations when altering tables. Specifically, the following scenarios were identified and fixed:

  1. Applying the addition of a column to the dropping of same column (now results in a column modification)
  2. Applying the modification of a column to any operation on that same column uses the original column name (instead of the new name if renamed)
  3. Applying the change of a column to any column operation on the same column uses that column's original name. In the case of an add, we clean up the new_name option on the column operation since it is not relevant.

Copy link
Contributor

@Glenn-Ewing Glenn-Ewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not pull this down to run things locally, but code changes look sane, and tests look like they cover the changes made.
Let me know if you'd prefer I pull and run locally, but short of that, these look like great enhancements, thanks @joshmcrae !

@joshmcrae joshmcrae merged commit 91a31c6 into master Nov 4, 2025
20 checks passed
@joshmcrae joshmcrae deleted the hotfix-reduce-modify branch November 4, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants