Added method prefix #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method prefix, used for methods added to native prototypes
Author
|
I forgot to mention...I used uglifyjs to create the minified version in the dist folder, but I noticed it wasn't minified in the same way as the original. I thought I'd mention this in case you want to generate the minified file with your preferred minifier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default prefix of an underscore to all methods added to native prototypes.
Note: After updating the tests, all tests passed except the underscore.string test of _classify(). I then checked the original repo and noticed it wasn't passing there either - maybe due to some change in the latest version of Underscore? In any case, I updated the test so it passes.
Resolves #5