Fix: Standardize outputs/ and improve GitHub token guidance#10
Merged
Conversation
This commit addresses two issues:
1. Standardize on "outputs/" directory across all skills
- Updated all IC skills to use outputs/ instead of generated/
- Updated AGENTS.md to reflect outputs/ as standard location
- Added clarifying comment to .gitignore
- Consistent paths: <profile-root>/outputs/ (IC) and reports/<id>/outputs/ (manager)
2. Add dual output to analysis skills
- Skills now both respond in-thread AND save to file
- In-thread response works with MCP and provides immediate feedback
- File output provides persistence for later reference
- Updated: detect-projects, detect-themes, summarize-work, generate-resume-bullets,
write-self-review, update-resume
3. Improve GitHub token scope requirements
- Clearly document read:org scope requirement for org discovery
- Update token prompts in init wizard (both IC and manager mode)
- Update auto-discovery option description to mention read:org
- Better error handling: detect INSUFFICIENT_SCOPES and show helpful message
- Update README with clear scope requirements
Files changed:
- Skills: 6 skills updated with dual output and outputs/ paths
- Init: Better token guidance and error messages
- Docs: AGENTS.md, README.md updated with clear requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two important consistency and usability issues:
outputs/directory across all skillsChanges
1. Directory Standardization
Before: Mixed use of
generated/(IC skills) andoutputs/(manager skills)After: Consistent use of
outputs/everywhere<profile-root>/outputs/Files updated:
AGENTS.md.gitignore2. Dual Output for Analysis Skills
Problem: Skills like
detect-projects,detect-themes,summarize-workonly responded in-thread. Users had no persistent file to reference later.Solution: All skills now do BOTH:
outputs/(for persistence and future reference)Skills updated:
work-chronicler-detect-projects→outputs/projects-detected-YYYY-MM-DD.mdwork-chronicler-detect-themes→outputs/themes-detected-YYYY-MM-DD.mdwork-chronicler-summarize-work→outputs/work-summary-YYYY-MM-DD.mdwork-chronicler-generate-resume-bullets→outputs/resume-bullets-YYYY-MM-DD.mdwork-chronicler-write-self-review→outputs/self-review-YYYY-MM-DD.mdwork-chronicler-update-resume→outputs/resume-updated-YYYY-MM-DD.md3. GitHub Token Scope Requirements
Problem:
read:orgscope requirement wasn't clear, causing auto-discovery to fail for organizations.Solution:
read:orgrequirementINSUFFICIENT_SCOPESand shows helpful messageExample improved error:
Files Changed
Testing
outputs/directoryread:orgscopeImpact