refactor(chart-engine): tighten typing for bar overlay modules #23
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 205a404a03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _number_list(value: object) -> list[Number]: | ||
| result: list[Number] = [] | ||
| for item in _list(value): | ||
| if isinstance(item, (int, float)): | ||
| result.append(item) |
There was a problem hiding this comment.
The new _number_list compacts arrays by removing non-numeric entries, but downstream category/total offset lookups are index-based and previously tolerated placeholders via _number(..., 0). With configs like category_label_offsets: [null, 12000] or total_label_offsets_x: [null, -8000], the second offset now shifts onto the first category and later categories lose their intended overrides, causing incorrect label placement in rendered charts.
Useful? React with 👍 / 👎.
| categories = _list(overlay.get("categories")) | ||
| totals = _float_or_none_list(overlay.get("totals")) | ||
| total_label_tops = _float_or_none_list(overlay.get("total_label_tops")) | ||
| series_names = _string_list(overlay.get("series_names")) |
There was a problem hiding this comment.
Filtering series_names through _string_list drops previously accepted non-string names (for example YAML name: 2024, parsed as an int). Earlier code rendered these names with str(name) in legend/label paths, but now they are removed before use, which can make series_names empty (skipping legend rendering entirely) and break name-based segment selectors for those series.
Useful? React with 👍 / 👎.
1 participant
Summary
Typing pass 4 for chart-engine bar overlays.
This removes broad file-level pyright suppressions from the remaining bar overlay orchestration/segment modules and replaces dynamic access with explicit typed normalization while preserving rendering behavior.
Changes
clean_slides/chart_engine/overlay_bar.py# pyrightsuppression headerclean_slides/chart_engine/overlay_bar_segments.py# pyrightsuppression headeradd_text_labelandresolve_txbody_templateValidation
.venv/bin/ruff check clean_slides/chart_engine/overlay_bar.py clean_slides/chart_engine/overlay_bar_segments.py.venv/bin/pyright clean_slides/chart_engine/overlay_bar.py clean_slides/chart_engine/overlay_bar_segments.py.venv/bin/pyright.venv/bin/pytest -q.venv/bin/pre-commit run --all-files