Skip to content

Conversation

@tmustier
Copy link
Owner

Summary

Add one more module-boundary smoke test for chart-engine builder behavior.

Changes

  • tests/test_chart_engine_smoke.py
    • added test_build_chart_defers_chart_template_copy_replacement

This test exercises:

  • build_chart(..., save=False, defer_template_copy=True)
  • bar spec with chart_template + chart_template_copy: true

And validates that:

  • exactly one ChartTemplateReplacement is queued
  • queued replacement points at the configured template path
  • replacement targets a chart part (ppt/charts/chart...)

This covers the deferred template-copy path at the chart-engine boundary without depending on CLI wiring.

Validation

  • .venv/bin/pyright
  • .venv/bin/pytest -q
  • .venv/bin/pre-commit run --all-files

@tmustier tmustier merged commit 24de9af into main Feb 12, 2026
7 checks passed
@tmustier tmustier deleted the test/chart-engine-smoke-replacements branch February 12, 2026 02:26
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c32d34fd25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +123 to +124
save=False,
defer_template_copy=True,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cover defer_template_copy branch by saving presentation

This test sets save=False, but build_chart only uses defer_template_copy inside the if save: block (clean_slides/chart_engine/builder.py), so the result here is identical whether defer_template_copy is True or False. In practice, this means the new test does not validate the deferred replacement behavior it claims to cover and would still pass if the defer logic regressed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant