Skip to content

Conversation

@tmustier
Copy link
Owner

Summary

Remove local pyright suppression pragmas from tests/test_charts_cli.py and make the test fakes/helpers strictly typed.

Changes

  • Removed per-file pyright suppression header from tests/test_charts_cli.py
  • Added typed helper _to_str_dict(...) for fake-engine spec normalization
  • Tightened _chart_types(...) with explicit runtime guards to avoid unknown member access
  • Updated _FakeEngine.normalize_chart_specs(...) to avoid unknown dict/list value propagation
  • Preserved all existing test behavior and expectations

Validation

  • .venv/bin/pyright tests/test_charts_cli.py
  • .venv/bin/pytest -q tests/test_charts_cli.py
  • .venv/bin/pre-commit run --all-files

@tmustier tmustier merged commit 895da29 into main Feb 12, 2026
7 checks passed
@tmustier tmustier deleted the test/charts-cli-typing-cleanup branch February 12, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant