refactor(typing): remove remaining local pyright suppressions#28
Merged
refactor(typing): remove remaining local pyright suppressions#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the strict-typing cleanup pass by removing remaining local pyright suppressions in runtime/test modules touched by chart + rendering workflows.
Changes
1) Chart/rendering test + module cleanup
clean_slides/chart_render.pyunknown member,unknown variable,private usage)_to_str_any_dict)etree._Elementprivate annotations in favor of saferAny-based XML handlingchart_def_to_specpython_fmt_to_excel_formatwaterfall_overlay_label_textstests/test_chart_cells.pytests/test_sizing.pyobject.__getattribute__) + typed callables2) Private-usage suppression removal in rendering/introspection helpers
clean_slides/xml_helpers.pyetree._Elementannotations with localXmlElementaliasclean_slides/renderer.pyetree._Elementannotations with localXmlElementaliasmake_sub_paragraph)clean_slides/content.pymake_sub_paragraph(...)for renderer useclean_slides/inspect_pptx.pyetree._Elementannotations with localXmlElementaliasValidation
.venv/bin/ruff check clean_slides tests.venv/bin/pyright.venv/bin/pytest -q.venv/bin/pre-commit run --all-filesResult
rg -n "^# pyright:" clean_slides testsnow returns only:clean_slides/constants.py(reportConstantRedefinition=false, intentional for mutable module-level reload pattern)