Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## RC_v1.6.x #538 +/- ##
=============================================
+ Coverage 63.55% 64.11% +0.56%
=============================================
Files 27 27
Lines 3858 3913 +55
=============================================
+ Hits 2452 2509 +57
+ Misses 1406 1404 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Linting results by Pylint:Your code has been rated at 8.33/10 (previous run: 8.34/10, -0.01) |
|
Should we consider this a major enough change to warrant being part of a 1.7 release? Or introduce it sooner but focus on adding more coordinate awareness (e.g. using lat/lon rather than fixed x/y spacing) for 1.7? |
I think we can hold this back for v1.7, although I think holding it back until we resolve all coordinate issues is probably not a great idea. I'm working on lat/lon tracking code now to resolve an issue I'm encountering with periodic boundaries on global data (namely that it can be slow), which would help. Because we're reliant on the scikit-learn distance metrics outside of using a python -> numba function, though, that function is intended to be 2D only, at least at first. |
My ideal is actually that we move to a world where we don't ask the user to input anything for |
|
I was thinking about this more - perhaps we can split this into two PRs: one to remove |
|
I noticed that in the basics example 'Idealized-Case-3_Tracking-of-a-Test-Blob-in-3D', |
Resolves #502 . Removes
get_spacingsfrom all tutorials, replacing it with explicit grid spacing and time interval declaration. Marksget_spacingsas deprecated.