feat(snowflake): add type annotation for DECODE function support #6199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-ashashankar
changed the title
Collaborator
Author
|
Decode function support is already available . added support to return type annotation for DECODE function. |
geooo109
reviewed
Oct 27, 2025
The annotation now determines the output type based solely on the return values (ret1, ret2, ..., default), ignoring comparison values.
VaggelisD
reviewed
Oct 28, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
This is a tough function to annotate, nice work! Leaving a few comments:
…implemented. Fixed the annotate_decode_case function to identify the returntype based on default param and added more tests
fivetran-ashashankar
requested review from
VaggelisD,
fivetran-BradfordPaskewitz and
georgesittas
VaggelisD
reviewed
Oct 29, 2025
georgesittas
requested changes
Oct 29, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Let's also add a DECODE(x, 1, 100, NULL) test case, see #6211 (review).
…Snowflake DECODE to verify correct type inference when one branch is NULL
…ents implemented.
…ents implemented.
georgesittas
approved these changes
Oct 30, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Great, thanks for addressing all comments @fivetran-ashashankar!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.