This repository was archived by the owner on Dec 28, 2022. It is now read-only.
Pr/invalid session #3191
Draft
Pr/invalid session #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: make heartbeat interval independent of session timeout Refs: TOCDEV-5313
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
==========================================
+ Coverage 82.07% 82.15% +0.08%
==========================================
Files 892 892
Lines 11173 11176 +3
==========================================
+ Hits 9170 9182 +12
+ Misses 2003 1994 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- only start heartbeat once and not after each login (which could lead to multiple heartbeats) - move sessionCheck to entity-browser as in the admin setAdminAllowed and setLoggedIn are already handled and the notification socket is already opened. loggedIn is not reimplemented in the widgets as it is currently not used Refs: TOCDEV-5313
Refs: TOCDEV-5313
if a field is focused and the invalid session modal is shown the focus is changed to the modal. This triggers the async validation. The server returns a 400 status code as the user is no longer logged in. This error should be ignored Changelog: allow 400 status code in async validation Refs: TOCDEV-5313
the LoadMask (loading the login and sso-login app) has a height of 100%. Without the div both load masks have the height of the modal itself. Layout in normal login screen is not changed Changelog: fix layout of login in modal Refs: TOCDEV-5313
the session invalid modal should have a higher z-index than all other modals and the toasters. so we cannot just reuse the functionality Changelog: add invalid session modal Refs: TOCDEV-5313
stewue
force-pushed
the
pr/invalid-session
branch
from
afbca1a to
2c4e490
Compare
Contributor
|
When logging in with a different user on the invalid session modal:
|
izzappel
reviewed
Nov 9, 2022
| yield call(cache.clearAll) | ||
| } | ||
| yield put(actions.setAdminAllowed(adminAllowed)) | ||
| yield put(actions.setLoggedIn(success)) |
Contributor
There was a problem hiding this comment.
So before we set adminAllowed before loggedIn. This caused that adminAllowed always had a value when Admin is rendered.
Now we set loggedIn separately and only set adminAllowed when we already render Admin component. This causes the prop types of Admin to be unhappy because adminAllowed prop is required.
I still try to understand all these changes.. nevertheless either the proptypes are not correct anymore or we need to be more careful with setting the loggedIn and adminAllowed values
Member
Author
There was a problem hiding this comment.
adminAllowed is set to undefined in the file packages/apps/admin/src/modules/session/sagas.js. So I think should the proptype was wrong
izzappel
approved these changes
Nov 9, 2022
during the login the adminAllowed prop is set to undefined Refs: TOCDEV-5313
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.