Skip to content

Conversation

@unlimitedsola
Copy link
Contributor

Backport of #2188 to the main branch.

@unlimitedsola unlimitedsola requested review from a team and hawkw as code owners July 26, 2025 22:05
@hds
Copy link
Contributor

hds commented Nov 19, 2025

@unlimitedsola Thanks for your PR! I'm going through some now, could you please rebase (and/or give maintainers access to change the PR).

Also, the same for #3350 and #3351.

Thanks!

The gitter room is not used anymore.
This commit updates CONTRIBUTING.md to guide the reader to the
discord channel.

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
(cherry picked from commit b310ed2)
@unlimitedsola
Copy link
Contributor Author

Thank you for reviewing this @hds , I've rebased this PR and others that you linked.

Unfortunately GitHub doesn't allow maintainers access if PRs are pulled from an organization, I follow my PRs closely so feel free to request any changes as you see fit.

Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hds hds enabled auto-merge (squash) November 19, 2025 16:51
@hds
Copy link
Contributor

hds commented Nov 19, 2025

@unlimitedsola OK, there's something I didn't know until today. You'll need to update each commit as a previous one goes in. Could you please ping me on each PR when it's ready. Since it's just 2 more, I'll try to merge yours in sequence to avoid unnecessary updates.

@hds hds merged commit a9e2778 into tokio-rs:main Nov 19, 2025
55 checks passed
@unlimitedsola
Copy link
Contributor Author

@hds I've rebased both other PRs. Feel free to merge whichever you prefer first! I'll rebase the other once more after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants