Open
Conversation
Fuminiton
reviewed
Aug 14, 2025
| if math.isinf(min_length): | ||
| return 0 | ||
| return min_length | ||
| ``` |
There was a problem hiding this comment.
特に問題ないと思います。
min_lengthの初期値を何にするかが悩ましいですよね。個人的には、len(nums)+1 だと、intである、min_lenとしてあり得ないことが分かる、想定の最大min_lenより大きくなった場合も対応できるといった観点でいいのかなと思いました。
Owner
Author
There was a problem hiding this comment.
ありがとうございます。len(nums)+1はいいですね。最後の比較するところがmin_length == len(nums)+1 だとわかりにくい気がしていて、以下のような感じかなと思っています。
NOT_FOUND = len(nums) + 1
min_length = NOT_FOUND
...
if min_length == NOT_FOUND:
return 0
return min_length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Problem
209. Minimum Size Subarray Sum
Next Ploblem
46. Permutations
言語: Python