Open
Conversation
ryosuketc
reviewed
Sep 5, 2025
| ```python | ||
| class Solution: | ||
| def nextPermutation(self, nums: List[int]) -> None: | ||
| n = len(nums) |
There was a problem hiding this comment.
len(nums) のような定数時間でアクセスでき、かつ極めてシンプルなものをあえて変数に置くと却って読みにくくなるかもしれません。
| for i in reversed(range(n - 1)): | ||
| if nums[i] < nums[i + 1]: | ||
| return i | ||
| return None |
There was a problem hiding this comment.
ここで何を返すかは議論の余地があると思いますが、rfind という名前を使うなら built-in の規則に合わせたくなります。
具体的には -1 を返していますね。
https://docs.python.org/ja/3.13/library/stdtypes.html#str.rfind
Owner
Author
There was a problem hiding this comment.
なるほど、その観点はありませんでした。個人的には -1 はインデックスとして成立してしまうので None を返したいと思って書きました。いずれにせよdocstringに書いた方が良いですね。ありがとうございます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Problem
31. Next Permutation
Next Ploblem
8. String to Integer (atoi)
言語: Python