Conversation
Version progress and tags would otherwise be disrupted. Besides, Patron is not "alpha" anymore, by far.
of the last 5 years 🤦
no need to seed a new RNG for every byte bag served out
We should not be managing those manually, and that's what Tempfiles are for and all
Collaborator
Author
|
@toland I'll leave this for you for a quick check for a couple of days, I believe everything here is in order - but just to be sure. There was also a valid question in #165 (comment) about GH releases - should we turn them off maybe? |
Collaborator
Author
|
@toland oh - would you like to update the author name in the gemspec? ❤️ |
Owner
Yes. Feel free to make the change. |
Owner
Yeah. They shouldn't show up on the repository page anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reasonably noted in #196 we haven't had a release in a while. Let's roll one.
I've reverted my stupid alpha version designator from version.rb and annotated the changes I could parse from the commit logs in CHANGELOG. I also noticed one of the get_file tests is failing on CI, I suspect it is either Linux-related or libCURL related since we set our buffers rather small. @marshall-lee if you have ideas why this would match exactly on Darwin but not on GH actions - let me know, it would be unfortunate if we are miscounting buffers someplace.
I've also taken the liberty to replace our
tmpfilepath usage with actual tempfiles (also with a#closelike in recent @marshall-lee changes).