Open
Conversation
mamo3gr
reviewed
Mar 29, 2026
122/sol2.py
Outdated
Comment on lines
+3
to
+4
| if not prices: | ||
| raise ValueError("The input list is empty") |
Owner
Author
There was a problem hiding this comment.
0を返す方が適切なように考え直しました。入力が空のときにprofitが0となるのは自然で、この場合にわざわざプログラムを停止させるのは使い勝手が悪そうですので。
mamo3gr
reviewed
Mar 29, 2026
122/sol2.py
Outdated
Comment on lines
+15
to
+18
| profit_holding_stock, profit_not_holding_stock = ( | ||
| next_profit_holding_stock, | ||
| next_profit_not_holding_stock, | ||
| ) |
There was a problem hiding this comment.
ここは単にそれぞれ代入する方が、より代入元と代入先が近くなって読みやすいと感じました。
Owner
Author
There was a problem hiding this comment.
swapするわけではないので多重代入する必要はないですね
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/best-time-to-buy-and-sell-stock-ii/