fix(ci): qodana-main-fail durch redundante usings beheben#114
Merged
tomtastisch merged 2 commits intomainfrom Feb 21, 2026
Merged
fix(ci): qodana-main-fail durch redundante usings beheben#114tomtastisch merged 2 commits intomainfrom
tomtastisch merged 2 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Behebt eine Main-Regression im CI, indem zwei von Qodana als RedundantUsingDirective geflaggte using-Direktiven aus Unit-Tests entfernt werden (kein Produktionscode betroffen).
Changes:
- Entfernt
using Tomtastisch.FileClassifier;ausStreamGuardUnitTests. - Entfernt
using Tomtastisch.FileClassifier;ausLogGuardUnitTests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/FileTypeDetectionLib.Tests/Unit/StreamGuardUnitTests.cs | Entfernt ein ungenutztes using, um Qodana-Finding zu beseitigen. |
| tests/FileTypeDetectionLib.Tests/Unit/LogGuardUnitTests.cs | Entfernt ein ungenutztes using, um Qodana-Finding zu beseitigen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ziel & Scope
qodanaund der davon abhaengigepreflight-Gate wieder bestehen.using-Direktiven in Testdateien.Umgesetzte Aufgaben (abhaken)
qodanaHigh+ Blocking Findings).usingentfernt).Nachbesserungen aus Review (iterativ)
resolved(inkl. outdated)Security- und Merge-Gates
Evidence (auditierbar)
Befehle/Evidence:
gh run view 22262987588 --json ...->CI-QODANA-004wegen High+ Blocking Findings.jq ... /tmp/run-22262987588/ci-qodana/report/results/result-allProblems.json-> 2 verbleibende High-FundeRedundantUsingDirective.dotnet build src/FileTypeDetection/FileTypeDetectionLib.vbproj -c Release --no-restore -v minimal-> Erfolg, 0 Warnungen, 0 Fehler.dotnet test tests/FileTypeDetectionLib.Tests/FileTypeDetectionLib.Tests.csproj -c Release --no-build -v minimal-> Erfolg, 551/551.DoD (mindestens 2 pro Punkt)
22262987588)CI-QODANA-004) mit Evidence belegtRisiken / Open Items
Details (nur falls vorhanden)