release(core): PR-108 audit-konform neu aufsetzen und stabilisieren#115
Closed
tomtastisch wants to merge 35 commits intomainfrom
Closed
release(core): PR-108 audit-konform neu aufsetzen und stabilisieren#115tomtastisch wants to merge 35 commits intomainfrom
tomtastisch wants to merge 35 commits intomainfrom
Conversation
Signed-off-by: Tomtastisch <82227609+tomtastisch@users.noreply.github.com>
…nz vorbe…" This reverts commit 4badf0f.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
bot
added
area:docs
area:versioning
area:tooling
impl:security
area:tests
breaking
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts PR #108, which attempted to implement version 6.0.1 with hashing finalization and version convergence. The revert is motivated by incomplete and faulty implementation of the original changes.
Changes:
- Reverts version from 6.0.1 back to 5.2.1 across all project files and documentation
- Reverts FileKind enum changes (Doc/Xls/Ppt → Docx/Xlsx/Pptx)
- Reverts HashRoundTripReport API from slot-based model back to direct property access
- Consolidates internal hashing modules back into EvidenceHashing.vb
- Removes Infrastructure/Utils submodule and moves code back to inline implementations
- Updates all tests to match the reverted API and enum values
Reviewed changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Reverts RepoVersion from 6.0.1 to 5.2.1 |
| SECURITY.md | Reverts supported version from 6.x back to 5.x |
| AGENTS.md | Removes workflow changes for single-comment iteration |
| src/FileTypeDetection/FileTypeDetectionLib.vbproj | Reverts Version and PackageVersion to 5.2.1 |
| src/FileTypeDetection/Abstractions/Detection/FileKind.vb | Reverts enum values (Doc→Docx, Xls→Xlsx, Ppt→Pptx) |
| src/FileTypeDetection/Abstractions/Hashing/HashRoundTripReport.vb | Reverts API from slot-based to direct properties (H1-H4) |
| src/FileTypeDetection/EvidenceHashing.vb | Consolidates internal hashing logic back into main file |
| src/FileTypeDetection/Detection/FileTypeRegistry.vb | Reverts FileKind references and inline magic pattern catalog |
| src/FileTypeDetection/Infrastructure/CoreInternals.vb | Moves utility code back inline from removed Utils module |
| tests/** | Updates all test files to match reverted FileKind enum values |
| docs/** | Reverts version history and security claims documentation |
…nto revert-108-codex/fix/sharpcompress-v1-api-compat
- move and consolidate utility logic under Infrastructure/Utils as SSOT - align style/policy with ArchiveInternals method header wrapping rules - bump version convergence to 6.0.1 and refresh docs/evidence - support SECURITY_CLAIMS_TOKEN fallback for remote version convergence - wire SECURITY_CLAIMS_TOKEN into ci version-convergence workflow step
- switch new module links to relative paths - use existing baseline tag v5.2.1 for 6.0.1 compare URLs
- move guard-focused utilities to Infrastructure/Utils/Guards - rename GuardUtils to ArgumentGuard and IoGuards to IOGuards - keep non-guard helpers (EnumUtils/IterableUtils) at Utils root - add Guards README and update governance/docs references
- add XML docs for internal ctor/helper members in HashEvidence - add XML docs for Clone/Normalize and filename normalization in HashOptions
- add XML docs for normalization/digest helper methods and NormalizedEntry members
- deduplicate early HashRoundTripReport failure construction - build alias map in stable FileKind order - remove unused SECURITY_CLAIMS_TOKEN from ci version-convergence job
- add missing HashDigestSet member docs per policy - replace ambiguous builder variable names in FileTypeRegistryConfig - initialize alias map temp variable to avoid warnings
github-actions
bot
added
docs
tomtastisch
changed the title
tomtastisch
deleted the
revert-108-codex/fix/sharpcompress-v1-api-compat
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ziel & Scope
src/FileTypeDetection/Infrastructure/Utilsinkl. Guard-Cluster.6.0.1gemäß Policy.Umgesetzte Aufgaben (abhaken)
Infrastructure/Utilsinkl.Guards/*wiederhergestellt.6.0.1konsistent gehalten.Nachbesserungen aus Review (iterativ)
resolved(inkl. outdated)Security- und Merge-Gates
Evidence (auditierbar)
Befehle/Evidence:
dotnet build src/FileTypeDetection/FileTypeDetectionLib.vbproj -c Release --no-restore -v minimal-> Erfolg, 0 Warnungen, 0 Fehler.dotnet test tests/FileTypeDetectionLib.Tests/FileTypeDetectionLib.Tests.csproj -c Release --no-build -v minimal-> Erfolg, 551/551.gh pr view 113 --json state->MERGED(gestapelter PR nicht mehr offen).docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD.DoD (mindestens 2 pro Punkt)
Infrastructure/Utilsinkl.Guards/*vorhandenRisiken / Open Items
Details (nur falls vorhanden)